hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hbase] Reidddddd commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Date Thu, 08 Aug 2019 04:30:00 GMT
Reidddddd commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy
loses its function after split
URL: https://github.com/apache/hbase/pull/460#discussion_r311851536
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 ##########
 @@ -7177,8 +7177,8 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws
IOException
     fs.commitDaughterRegion(hri);
 
     // Create the daughter HRegion instance
-    HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(),
-        this.getBaseConf(), hri, this.getTableDesc(), rsServices);
+    HRegion r = HRegion.newHRegion(this.fs.getTableDir(), rsServices.getWAL(hri),
 
 Review comment:
   > rsServices.getWAL(hri)
   
   Based on WALProvider impl, it will create a new wal according to strategy or inherit parent
by default mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message