From issues-return-377585-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Tue Feb 12 00:06:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1FC6F180648 for ; Tue, 12 Feb 2019 01:06:03 +0100 (CET) Received: (qmail 58726 invoked by uid 500); 12 Feb 2019 00:06:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 58715 invoked by uid 99); 12 Feb 2019 00:06:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2019 00:06:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C0FB3C1DDE for ; Tue, 12 Feb 2019 00:06:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id l2H-9JDP_-7S for ; Tue, 12 Feb 2019 00:06:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CF4DD5F58B for ; Tue, 12 Feb 2019 00:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7A654E2782 for ; Tue, 12 Feb 2019 00:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2ADF42447C for ; Tue, 12 Feb 2019 00:06:00 +0000 (UTC) Date: Tue, 12 Feb 2019 00:06:00 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-21863) narrow down the double-assignment race window MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-21863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765553#comment-16765553 ] Sergey Shelukhin commented on HBASE-21863: ------------------------------------------ [~stack] can you elaborate on extra states from deadline? If the message did expire (master is no longer waiting), we avoid doing something master doesn't expect. If it doesn't expire and we respond with error, it happens before any work, so the master will just handle it like a regular error. It's not ideal but should be rare and doesn't add new states. I'd like to add it to region report, however it causes some issues: HBASE-21522 and especially HBASE-21531 that is a race that happens a lot. So it was removed in HBASE-21421. I filed a separate JIRA to add it back. I think given that TRSP is one place that sort of knows what's going on, it's a good place to have it for now :) Ignoring some RS reporting region open doesn't seem to be correct. I can replace with a more specific exception. There's discussion in the other bug about the root cause... However, for production use it's better to prevent double assignment due to unknown bugs, to avoid data loss... > narrow down the double-assignment race window > --------------------------------------------- > > Key: HBASE-21863 > URL: https://issues.apache.org/jira/browse/HBASE-21863 > Project: HBase > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Priority: Major > Attachments: HBASE-21863.patch > > > See HBASE-21862. -- This message was sent by Atlassian JIRA (v7.6.3#76005)