From issues-return-365556-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Tue Oct 16 17:50:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0A13B180778 for ; Tue, 16 Oct 2018 17:50:04 +0200 (CEST) Received: (qmail 41985 invoked by uid 500); 16 Oct 2018 15:50:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 41847 invoked by uid 99); 16 Oct 2018 15:50:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2018 15:50:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 430F31807B4 for ; Tue, 16 Oct 2018 15:50:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Oby0lWWeCXML for ; Tue, 16 Oct 2018 15:50:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E53495F5A9 for ; Tue, 16 Oct 2018 15:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0679FE262F for ; Tue, 16 Oct 2018 15:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6D3F624DF1 for ; Tue, 16 Oct 2018 15:50:00 +0000 (UTC) Date: Tue, 16 Oct 2018 15:50:00 +0000 (UTC) From: "Allan Yang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-21315) The getActiveMinProcId and getActiveMaxProcId of BitSetNode are incorrect if there are no active procedure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-21315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651964#comment-16651964 ] Allan Yang commented on HBASE-21315: ------------------------------------ {code} - if ((deleted[i] & (1L << j)) != 0) { + if ((deleted[i] & (1L << j)) == 0) { {code} Incredible! This logic is wrong all the time? > The getActiveMinProcId and getActiveMaxProcId of BitSetNode are incorrect if there are no active procedure > ---------------------------------------------------------------------------------------------------------- > > Key: HBASE-21315 > URL: https://issues.apache.org/jira/browse/HBASE-21315 > Project: HBase > Issue Type: Sub-task > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Major > Fix For: 3.0.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-21315.patch > > > Found by [~allan163]. If no active procedure, we will return the start as the min proc id, and getEnd() as the max proc id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)