hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Reid Chan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-20896) Port HBASE-20866 to branch-1 and branch-1.4
Date Wed, 01 Aug 2018 02:15:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-20896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563828#comment-16563828
] 

Reid Chan edited comment on HBASE-20896 at 8/1/18 2:14 AM:
-----------------------------------------------------------

Thanks for your feedback, then we can just keep {{LinkedList}}, no great big deal. {{LinkedList}}
cache makes sense to me, since we can't predict how large a client scan can be.

One more place i found today,
we can have a default {{clear()}} implementation in {{ScanResultCache}}, inheritances can:
{code}
void clear() {
  super.clear();
  // own clear.
}
{code}


was (Author: reidchan):
Thanks for your feedback, then we can just keep {{LinkedList}}, no great big deal. {{LinkedList}}
cache makes sense to me, since we can predict how large a client scan can be.

One more place i found today,
we can have a default {{clear()}} implementation in {{ScanResultCache}}, inheritances can:
{code}
void clear() {
  super.clear();
  // own clear.
}
{code}

> Port HBASE-20866 to branch-1 and branch-1.4 
> --------------------------------------------
>
>                 Key: HBASE-20896
>                 URL: https://issues.apache.org/jira/browse/HBASE-20896
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>            Assignee: Vikas Vishwakarma
>            Priority: Major
>             Fix For: 1.5.0, 1.4.7
>
>         Attachments: HBASE-20896.branch-1.4.001.patch, HBASE-20896.branch-1.4.002.patch,
HBASE-20896.branch-1.4.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message