hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Reid Chan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18201) add UT and docs for DataBlockEncodingTool
Date Mon, 02 Jul 2018 03:58:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529362#comment-16529362
] 

Reid Chan commented on HBASE-18201:
-----------------------------------

Dug deeper, and got your concern.
Would you mind adding some comments {{// ...}} on the if branch why this branch is needed.

> add UT and docs for DataBlockEncodingTool
> -----------------------------------------
>
>                 Key: HBASE-18201
>                 URL: https://issues.apache.org/jira/browse/HBASE-18201
>             Project: HBase
>          Issue Type: Sub-task
>          Components: tooling
>            Reporter: Chia-Ping Tsai
>            Assignee: Kuan-Po Tseng
>            Priority: Minor
>              Labels: beginner
>         Attachments: HBASE-18201.master.001.patch, HBASE-18201.master.002.patch, HBASE-18201.master.002.patch,
HBASE-18201.master.003.patch
>
>
> There is no example, documents, or tests for DataBlockEncodingTool. We should have it
friendly if any use case exists. Otherwise, we should just get rid of it because DataBlockEncodingTool
presumes that the implementation of cell returned from DataBlockEncoder is KeyValue. The presume
may obstruct the cleanup of KeyValue references in the code base of read/write path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message