From issues-return-341774-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Tue Apr 3 21:22:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C216D18064D for ; Tue, 3 Apr 2018 21:22:06 +0200 (CEST) Received: (qmail 81712 invoked by uid 500); 3 Apr 2018 19:22:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 81701 invoked by uid 99); 3 Apr 2018 19:22:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2018 19:22:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5550CC035E for ; Tue, 3 Apr 2018 19:22:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ZHLIp4_hdbVi for ; Tue, 3 Apr 2018 19:22:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 79A685FC3F for ; Tue, 3 Apr 2018 19:22:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 163D4E0F18 for ; Tue, 3 Apr 2018 19:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6B52725621 for ; Tue, 3 Apr 2018 19:22:00 +0000 (UTC) Date: Tue, 3 Apr 2018 19:22:00 +0000 (UTC) From: "Thiruvel Thirumoolan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-20322) CME in StoreScanner causes region server crash MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-20322?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 24475#comment-16424475 ]=20 Thiruvel Thirumoolan commented on HBASE-20322: ---------------------------------------------- [~apurtell] - There is a small bug in=C2=A0patch=C2=A0which=C2=A0causes=C2= =A0TestAtomicOperation to fail.=C2=A0I see the bug at-least once when I run= TestAtomicOperation 25 times. Pls let me know if you would=C2=A0like me to= follow up=C2=A0on a separate Jira. I have attached the addendum along. > CME in StoreScanner causes region server crash > ---------------------------------------------- > > Key: HBASE-20322 > URL: https://issues.apache.org/jira/browse/HBASE-20322 > Project: HBase > Issue Type: Bug > Affects Versions: 1.3.2 > Reporter: Thiruvel Thirumoolan > Assignee: Thiruvel Thirumoolan > Priority: Major > Fix For: 1.5.0, 1.3.3, 1.4.4 > > Attachments: HBASE-20322.branch-1.3.001.patch, HBASE-20322.branch= -1.3.002-addendum.patch, HBASE-20322.branch-1.3.002.patch, HBASE-20322.bran= ch-1.4.001.patch > > > RS crashed with ConcurrentModificationException on our 1.3 cluster, stack= trace below. [~toffer]=C2=A0and I checked and there is a race condition be= tween flush and scanner close. When StoreScanner.updateReaders() is updatin= g the scanners after a newly flushed file (in this=C2=A0trace below a regio= n close during a split), the=C2=A0client's scanner could be closing thus ca= using CME. > Its rare, but since it crashes the region server, needs to be fixed. > FATAL regionserver.HRegionServer [regionserver/] : ABORTING region se= rver : Replay of WAL required. Forcing server shutdown > org.apache.hadoop.hbase.DroppedSnapshotException: region: > at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndComm= it(HRegion.java:2579) > at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegio= n.java:2255) > at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegio= n.java:2217) > at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegio= n.java:2207) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1501= ) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1420) > at org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforeP= ONR(SplitTransactionImpl.java:398) > at org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaught= ers(SplitTransactionImpl.java:278) > at org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(Spli= tTransactionImpl.java:566) > at org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitReq= uest.java:82) > at org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.jav= a:154) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.j= ava:1142) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.= java:617) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.util.ConcurrentModificationException > at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901) > at java.util.ArrayList$Itr.next(ArrayList.java:851) > at org.apache.hadoop.hbase.regionserver.StoreScanner.clearAndClose(StoreS= canner.java:797) > at org.apache.hadoop.hbase.regionserver.StoreScanner.updateReaders(StoreS= canner.java:825) > at org.apache.hadoop.hbase.regionserver.HStore.notifyChangedReadersObserv= ers(HStore.java:1155) > PS: ignore the line no in the above stack trace, method calls should help= understand whats happening. -- This message was sent by Atlassian JIRA (v7.6.3#76005)