hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-20395) Displaying thrift server type on the thrift page
Date Fri, 13 Apr 2018 02:35:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-20395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436711#comment-16436711
] 

Ted Yu commented on HBASE-20395:
--------------------------------

Your patch changes SERVER_TYPE_CONF_KEY. Is that absolutely necessary ?
{code}
+    // set the thrift server type
+    conf.set("hbase.regionserver.thrift.server.type", ThriftMetrics.ThriftServerType.TWO.name());
{code}
Since the value for the new config is only used by .jsp, you can choose a different config
key so that the existing config stays the same.

bq. Do you mean to set ThriftMetrics or ThriftServer instance as an attribute of InfoServer

bq. infoServer.setAttribute("hbase.thrift.metric", metrics);

You don't need to pass the metrics instance - you just need to pass the ThriftMetrics.ThriftServerType

Thanks

> Displaying thrift server type on the thrift page
> ------------------------------------------------
>
>                 Key: HBASE-20395
>                 URL: https://issues.apache.org/jira/browse/HBASE-20395
>             Project: HBase
>          Issue Type: Improvement
>          Components: Thrift
>            Reporter: Guangxu Cheng
>            Assignee: Guangxu Cheng
>            Priority: Major
>         Attachments: HBASE-20395.master.001.patch, HBASE-20395.master.002.patch, result.png
>
>
> HBase supports two types of thrift server: thrift and thrift2.
> But after start the thrift server successfully, we can not get the thrift server type
conveniently. 
> So, displaying thrift server type on the thrift page may provide some convenience for
the users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message