From issues-return-341125-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Thu Mar 29 10:25:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CF4E1180645 for ; Thu, 29 Mar 2018 10:25:03 +0200 (CEST) Received: (qmail 71401 invoked by uid 500); 29 Mar 2018 08:25:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 71386 invoked by uid 99); 29 Mar 2018 08:25:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 08:25:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E5C0AC036E for ; Thu, 29 Mar 2018 08:25:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Y8mslEiKEV7Q for ; Thu, 29 Mar 2018 08:25:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CFBA95F2F1 for ; Thu, 29 Mar 2018 08:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 560C8E0272 for ; Thu, 29 Mar 2018 08:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 12FE7255EB for ; Thu, 29 Mar 2018 08:25:00 +0000 (UTC) Date: Thu, 29 Mar 2018 08:25:00 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-20303) RS RPC server should not allow the response queue size to be too large MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-20303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418595#comment-16418595 ] Duo Zhang commented on HBASE-20303: ----------------------------------- {quote} How about SimpleRpcServer? Do I need to do it? {quote} Can be another issue I think. > RS RPC server should not allow the response queue size to be too large > ---------------------------------------------------------------------- > > Key: HBASE-20303 > URL: https://issues.apache.org/jira/browse/HBASE-20303 > Project: HBase > Issue Type: Improvement > Components: rpc > Affects Versions: 3.0.0 > Environment: 2000+ Region Servers > Reporter: Chance Li > Assignee: Chance Li > Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20303.master.v1.patch > > > With async clients, in some scenarios RS RPC server will occur Full GC because of the large reponse queue. > Netty provides a WriteBufferHighWaterMark on channel, But this doesn't meet RS's needs(Consider 5k ~ 10k sockets in one RS server, it will need 50G ~ 100G heap for 10M per channel). > RS rpc server will add a gloabl response buffer water mark(2G by default). when reaching the throttle, RS will not serve any request. > And RS rpc server will add a water mark for channel (100M by default), because it's mostly possible that this client is abnomal. > We created a unit test to simulate abnormal case: a client that has only 1 socket can lead RS server to occupy heap up to 100M. > > Notes: > 1. For client compability, we still use existed exception(CALL_QUEUE_TOO_BIG_EXCEPTION) but error message is different. > 2. Not for SimpleRpcServer, because It's rarely used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)