From issues-return-337485-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Fri Mar 9 14:20:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 42235180676 for ; Fri, 9 Mar 2018 14:20:06 +0100 (CET) Received: (qmail 90477 invoked by uid 500); 9 Mar 2018 13:20:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 90395 invoked by uid 99); 9 Mar 2018 13:20:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Mar 2018 13:20:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A67F1180920 for ; Fri, 9 Mar 2018 13:20:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id qYF4ZEtlDCno for ; Fri, 9 Mar 2018 13:20:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B91B95F5B1 for ; Fri, 9 Mar 2018 13:20:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9057AE0968 for ; Fri, 9 Mar 2018 13:20:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D2182143C for ; Fri, 9 Mar 2018 13:20:01 +0000 (UTC) Date: Fri, 9 Mar 2018 13:20:01 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-20160) TestRestartCluster.testRetainAssignmentOnRestart uses the wrong condition to decide whether the assignment is finished MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-20160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392873#comment-16392873 ] Hudson commented on HBASE-20160: -------------------------------- Results for branch master [build #256 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/256/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/256//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/256//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/256//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > TestRestartCluster.testRetainAssignmentOnRestart uses the wrong condition to decide whether the assignment is finished > ---------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-20160 > URL: https://issues.apache.org/jira/browse/HBASE-20160 > Project: HBase > Issue Type: Bug > Components: Region Assignment > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20160.patch > > > {code} > // Wait till master is initialized and all regions are assigned > RegionStates regionStates = master.getAssignmentManager().getRegionStates(); > int expectedRegions = regionToRegionServerMap.size() + 1; > while (!master.isInitialized() > || regionStates.getRegionAssignments().size() != expectedRegions) { > Threads.sleep(100); > } > {code} > Actually this does not mean the assignment is finished. In AMv2, we will load the region state from meta when restarting, so the regionStates.getRegionAssignments will reach the expected count soon. But this is just the old location. After that, we will continue to execute the ServerCrashProcedure to deal with the reassignment. That's why sometimes we may fail with > {noformat} > java.lang.AssertionError: Values should be different. Actual: 1520478964169 > at org.apache.hadoop.hbase.master.TestRestartCluster.testRetainAssignmentOnRestart(TestRestartCluster.java:215) > {noformat} > We just read the old location from meta since the ServerCrashProcedure has not been finished yet, but we want to confirm that the region is on the same host and port but a new RS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)