From issues-return-338494-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Thu Mar 15 12:35:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 06837180654 for ; Thu, 15 Mar 2018 12:35:06 +0100 (CET) Received: (qmail 90176 invoked by uid 500); 15 Mar 2018 11:35:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 90165 invoked by uid 99); 15 Mar 2018 11:35:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2018 11:35:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 791EA1A0212 for ; Thu, 15 Mar 2018 11:35:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id WXPdrBuXdoB1 for ; Thu, 15 Mar 2018 11:35:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E1EBB5F175 for ; Thu, 15 Mar 2018 11:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1D3B1E0446 for ; Thu, 15 Mar 2018 11:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 826C521496 for ; Thu, 15 Mar 2018 11:35:00 +0000 (UTC) Date: Thu, 15 Mar 2018 11:35:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-20119) Introduce a pojo class to carry coprocessor information in order to make TableDescriptorBuilder accept multiple cp at once MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-20119?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 00271#comment-16400271 ]=20 Hadoop QA commented on HBASE-20119: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 41s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} = 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {colo= r} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 90 new or modi= fied test files. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 4m 18s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5= m 56s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 4m 3s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}= 4m 0s{color} | {color:green} branch has no errors when building our shad= ed downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 6m 3s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2= m 27s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 3m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5= m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 27s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 34s{color} | {color:green} hbase-client generated 0 new + 103 unchanged - 1= fixed =3D 103 total (was 104) {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m = 39s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 29s{color} | {color:green} hbase-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 33s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 20s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 29s{color} | {color:green} hbase-endpoint in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 26s{color} | {color:green} hbase-it in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 24s{color} | {color:green} hbase-examples in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 18s{color} | {color:green} hbase-client-project in the patch passed. {color= } | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 24s{color} | {color:green} The patch hbase-common passed checkstyle {c= olor} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 34s{color} | {color:green} hbase-client: The patch generated 0 new + 2= 73 unchanged - 8 fixed =3D 273 total (was 281) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 26s{color} | {color:green} hbase-server: The patch generated 0 new + 9= 56 unchanged - 3 fixed =3D 956 total (was 959) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 19s{color} | {color:green} The patch hbase-mapreduce passed checkstyle= {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 11s{color} | {color:green} The patch hbase-rsgroup passed checkstyle {= color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 11s{color} | {color:green} The patch hbase-shell passed checkstyle {co= lor} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 12s{color} | {color:green} The patch hbase-endpoint passed checkstyle = {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 22s{color} | {color:green} The patch hbase-it passed checkstyle {color= } | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 13s{color} | {color:green} The patch hbase-examples passed checkstyle = {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 11s{color} | {color:green} The patch hbase-client-project passed check= style {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 8s{= color} | {color:red} The patch generated 1 new + 392 unchanged - 0 fixed = =3D 393 total (was 392) {color} | | {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} = 0m 3s{color} | {color:green} There were no new ruby-lint issues. {color} = | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}= 4m 5s{color} | {color:green} patch has no errors when building our shade= d downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green= } 14m 57s{color} | {color:green} Patch does not cause any errors with Hadoo= p 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 6m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2= m 28s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 1= 7s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 5= 5s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}110m 5= 9s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 14m 3= 2s{color} | {color:green} hbase-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 2= 2s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 4= 5s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m = 2s{color} | {color:green} hbase-endpoint in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m = 1s{color} | {color:green} hbase-it in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m = 0s{color} | {color:green} hbase-examples in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m = 9s{color} | {color:green} hbase-client-project in the patch passed. {color}= | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 3m 44s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}220m 44s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hbase:9f2f2d= b | | JIRA Issue | HBASE-20119 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1291465= 4/HBASE-20119.branch-2.v0.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars = hadoopcheck hbaseanti checkstyle compile rubocop ruby_lint | | uname | Linux 56295bb9c097 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 1= 4:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build= /component/dev-support/hbase-personality.sh | | git revision | branch-2 / 5ea0db0b1f | | maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f29= 5297; 2018-02-24T19:49:05Z) | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC3 | | rubocop | v0.53.0 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/11971/artif= act/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11971= /testReport/ | | Max. process+thread count | 4561 (vs. ulimit of 10000) | | modules | C: hbase-common hbase-client hbase-server hbase-mapreduce hbase= -rsgroup hbase-shell hbase-endpoint hbase-it hbase-examples hbase-archetype= s/hbase-client-project U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1197= 1/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Introduce a pojo class to carry coprocessor information in order to make = TableDescriptorBuilder accept multiple cp at once > -------------------------------------------------------------------------= ------------------------------------------------- > > Key: HBASE-20119 > URL: https://issues.apache.org/jira/browse/HBASE-20119 > Project: HBase > Issue Type: Task > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-20119.branch-2.v0.patch, HBASE-20119.v0.patch.= patch, HBASE-20119.v1.patch.patch, HBASE-20119.v2.patch, HBASE-20119.v3.pat= ch > > > The way to add cp to TableDescriptorBuilder is shown below. > {code:java} > public TableDescriptorBuilder addCoprocessor(String className) throws IOE= xception { > return addCoprocessor(className, null, Coprocessor.PRIORITY_USER, null)= ; > } > public TableDescriptorBuilder addCoprocessor(String className, Path jarFi= lePath, > int priority, final Map kvs) throws IOException { > desc.addCoprocessor(className, jarFilePath, priority, kvs); > return this; > } > public TableDescriptorBuilder addCoprocessorWithSpec(final String specStr= ) throws IOException { > desc.addCoprocessorWithSpec(specStr); > return this; > }{code} > When loading our config to create table with multiple cps, we have to wri= te the ugly for-loop. > {code:java} > val builder =3D TableDescriptorBuilder.newBuilde(tableName) > .setAAA() > .setBBB() > cps.map(toHBaseCp).foreach(builder.addCoprocessor) > cfs.map(toHBaseCf).foreach(builder.addColumnFamily) > admin.createTable(builder.build()) > {code} > If we introduce a pojo to carry the cp data and add the method accepting = multiple cps and cfs, it is easier to exercise the fluent interface of Tabl= eDescriptorBuilder. > {code:java} > admin.createTable(TableDescriptorBuilder.newBuilde(tableName) > .addCoprocessor(cps.map(toHBaseCp).asJavaCollection) > .addColumnFamily(cf.map(toHBaseCf).asJavaCollection) > .setAAA() > .setBBB() > .build){code} > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)