hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "huaxiang sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-20229) ConnectionImplementation.locateRegions() returns duplicated entries when region replication is on
Date Fri, 23 Mar 2018 14:06:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411430#comment-16411430
] 

huaxiang sun commented on HBASE-20229:
--------------------------------------

[~brfrn169], Sorry, do not mean to hijack the jira. I think your fix is good to go, we can
open another Jira to address my comments, thanks. +1 here and I will commit sometime today. 

> ConnectionImplementation.locateRegions() returns duplicated entries when region replication
is on
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20229
>                 URL: https://issues.apache.org/jira/browse/HBASE-20229
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Toshihiro Suzuki
>            Assignee: Toshihiro Suzuki
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: HBASE-20229.master.001.patch, HBASE-20229.master.002.patch, HBASE-20229.master.003.patch,
HBASE-20229.master.004.patch
>
>
> The issue is when region replication is on, ConnectionImplementation.locateRegions()
returns duplicated entries.
> In the test in my patch, the table should have 1 primary region + 2 secondaries, but
ConnectionImplementation.locateRegions() returns 9 regions. Every region repeats 3 times (3
= replicas count).
> I think this is because the following code calls locateRegion() even for replica regions
and then the result triples.
> {code:java}
>     for (RegionInfo regionInfo : regions) {
>       RegionLocations list = locateRegion(tableName, regionInfo.getStartKey(), useCache,
true);
>       if (list != null) {
>         for (HRegionLocation loc : list.getRegionLocations()) {
>           if (loc != null) {
>             locations.add(loc);
>           }
>         }
>       }
> {code}
> The fix in my patch is to make it call locateRegion() only for a primary region.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message