hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-20180) Avoid Class::newInstance
Date Wed, 14 Mar 2018 22:18:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-20180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399535#comment-16399535
] 

Andrew Purtell commented on HBASE-20180:
----------------------------------------

> The suggested replacement is {{getDeclaredConstructor().newInstance()}}, 

error-prone flagged this issue in branch-1 code and wherever I saw it I made the replacement
in earlier work. [~mdrob] if you can find occurrences I missed by all means.

> Avoid Class::newInstance
> ------------------------
>
>                 Key: HBASE-20180
>                 URL: https://issues.apache.org/jira/browse/HBASE-20180
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Major
>              Labels: error-prone
>         Attachments: HBASE-20180.patch, HBASE-20180.v2.patch, HBASE-20180.v3.patch
>
>
> Class::newInstance is deprecated starting in Java 9 - https://bugs.openjdk.java.net/browse/JDK-6850612
- because it may throw undeclared checked exceptions. The suggested replacement is {{getDeclaredConstructor().newInstance()}},
which will wrap the checked exceptions in InvocationException.
> There's even an error-prone warning about it, we should promote that to error while we're
fixing this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message