hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-20094) Import$CellWritableComparable should define equals()
Date Fri, 02 Mar 2018 21:01:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-20094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384143#comment-16384143
] 

stack commented on HBASE-20094:
-------------------------------

[~dbist13] Pardon me. I should have been more clear.

HBASE-20110 "Findbugs in zk and mr caused nightly #409 branch-2 to fail" added the below on
the compareTo of CellWritableComparable

{code}
221	    @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "EQ_COMPARETO_USE_OBJECT_EQUALS",
222	        justification = "This is wrong, yes, but we should be purging Writables, not fixing
them")
{code}

It did this to shutdown the findbugs warning.

The above change echoed the change made in the class above it, KeyValueWritableComparator,
done for the same reason.

I went this route of shutting down the findbugs warnings rather than addressing the complaint
as you have done here because these Writable classes need to go. Writables are the old Hadoop
POJO class serialization. Long time ago, we figured the hand-written serializations required
of Writables untenable and we opted for protobufs. These instances of Writables here are some
of the last in the codebase. Would rather work on their purge than fill them out more.

Thanks too for the initiative pushing back reopening the issue to address a hole.

> Import$CellWritableComparable should define equals()
> ----------------------------------------------------
>
>                 Key: HBASE-20094
>                 URL: https://issues.apache.org/jira/browse/HBASE-20094
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Artem Ervits
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: HBASE-20094.v01.patch, HBASE-20094.v02.patch
>
>
> Bug type EQ_COMPARETO_USE_OBJECT_EQUALS
> {code}
> In class org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable
> In method org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable.compareTo(Import$CellWritableComparable)
> At Import.java:[line 149]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message