hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19969) Improve FT in merge operation
Date Thu, 08 Mar 2018 00:47:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390526#comment-16390526

Ted Yu commented on HBASE-19969:

+      Path tmpBackupDir = new Path(HBackupFileSystem.getBackupTmpDirForBackupId(backupRoot,
I looked at the calls to HBackupFileSystem.getBackupTmpDirForBackupId where return value is
wrapped by Path.
It would be cleaner if HBackupFileSystem.getBackupTmpDirForBackupId() returns Path.
+  protected void copyFile(FileSystem fs, Path p, Path newPath) throws IOException {
Can you add javadoc to the above method ? It is easier to understand what the two Paths are
+    boolean exists = fs.exists(newPath);
+    LOG.debug("copyFile: "+ newPath+" exists="+exists);
The method throws IOException. If newPath doesn't exist, throwing IOException is better.
+    Path pp = p;
Unused variable.

> Improve FT in merge operation
> -----------------------------
>                 Key: HBASE-19969
>                 URL: https://issues.apache.org/jira/browse/HBASE-19969
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Major
>         Attachments: HBASE-19969-v1.patch
> Some file system operations are not fault tolerant during merge. We delete backup data
in a backup file system, then copy new data over to backup destination. Deletes can be partial,
copy can fail as well

This message was sent by Atlassian JIRA

View raw message