From issues-return-332887-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Wed Feb 7 23:12:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id DE8DD18065B for ; Wed, 7 Feb 2018 23:12:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CE8EC160C5B; Wed, 7 Feb 2018 22:12:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EE5D6160C3A for ; Wed, 7 Feb 2018 23:12:04 +0100 (CET) Received: (qmail 68563 invoked by uid 500); 7 Feb 2018 22:12:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68552 invoked by uid 99); 7 Feb 2018 22:12:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 22:12:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 95CFEC00F2 for ; Wed, 7 Feb 2018 22:12:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id E3ola0moA7Dk for ; Wed, 7 Feb 2018 22:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E89E65F11F for ; Wed, 7 Feb 2018 22:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F0A9FE018A for ; Wed, 7 Feb 2018 22:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F29E240F6 for ; Wed, 7 Feb 2018 22:12:00 +0000 (UTC) Date: Wed, 7 Feb 2018 22:12:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-19876) The exception happening in converting pb mutation to hbase.mutation messes up the CellScanner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-19876?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 56151#comment-16356151 ]=20 Hadoop QA commented on HBASE-19876: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m = 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} = 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {colo= r} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 1 new or modif= ied test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 3m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0= m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}= 5m 8s{color} | {color:green} branch has no errors when building our shad= ed downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 25s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 4m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0= m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m = 38s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 5= 8s{color} | {color:red} hbase-server: The patch generated 2 new + 130 uncha= nged - 0 fixed =3D 132 total (was 130) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}= 4m 10s{color} | {color:green} patch has no errors when building our shade= d downstream artifacts. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m = 10s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {co= lor} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m = 8s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.4. {co= lor} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m = 16s{color} | {color:red} The patch causes 10 errors with Hadoop v3.0.0. {co= lor} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 25s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 93m = 3s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 15s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}120m 15s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hbase:eee3b0= 1 | | JIRA Issue | HBASE-19876 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1290966= 2/HBASE-19876.v4.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars = hadoopcheck hbaseanti checkstyle compile | | uname | Linux afc2078b2513 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:= 48:03 UTC 2016 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build= /component/dev-support/hbase-personality.sh | | git revision | master / d95940776e | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a= 5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/11438/ar= tifact/patchprocess/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11438= /testReport/ | | Max. process+thread count | 5350 (vs. ulimit of 10000) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1143= 8/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > The exception happening in converting pb mutation to hbase.mutation messe= s up the CellScanner > -------------------------------------------------------------------------= -------------------- > > Key: HBASE-19876 > URL: https://issues.apache.org/jira/browse/HBASE-19876 > Project: HBase > Issue Type: Bug > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Priority: Critical > Fix For: 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-2, 1.4.2 > > Attachments: HBASE-19876.master.001.patch, HBASE-19876.v0.patch, = HBASE-19876.v1.patch, HBASE-19876.v2.patch, HBASE-19876.v3.patch, HBASE-198= 76.v3.patch, HBASE-19876.v3.patch, HBASE-19876.v3.patch, HBASE-19876.v4.pat= ch > > > {code:java} > 2018-01-27 22:51:43,794 INFO [hconnection-0x3291b443-shared-pool11-t6] c= lient.AsyncRequestFutureImpl(778): id=3D5, table=3DtestQuotaStatusFromMaste= r3, attempt=3D6/16 failed=3D20ops, last exception=3Dorg.apache.hadoop.hbase= .client.WrongRowIOException: org.apache.hadoop.hbase.client.WrongRowIOExcep= tion: The row in xxx doesn't match the original one aaa > =09at org.apache.hadoop.hbase.client.Mutation.add(Mutation.java:776) > =09at org.apache.hadoop.hbase.client.Put.add(Put.java:282) > =09at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(Protobuf= Util.java:642) > =09at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcS= ervices.java:952) > =09at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegio= nMutation(RSRpcServices.java:896) > =09at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServi= ces.java:2591) > =09at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$Clie= ntService$2.callBlockingMethod(ClientProtos.java:41560) > =09at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:404) > =09at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) > =09at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.jav= a:324) > =09at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.jav= a:304){code} > I noticed this bug when testing the table space quota. > When rs are converting pb mutation to hbase.mutation, the quota exception= or cell exception may be thrown. > {code} > Unable to find source-code formatter for language: rsrpcservices#dobatcho= p.java. Available languages are: actionscript, ada, applescript, bash, c, c= #, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, = json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh= , sql, swift, visualbasic, xml, yaml for (ClientProtos.Action action: = mutations) { > MutationProto m =3D action.getMutation(); > Mutation mutation; > if (m.getMutateType() =3D=3D MutationType.PUT) { > mutation =3D ProtobufUtil.toPut(m, cells); > batchContainsPuts =3D true; > } else { > mutation =3D ProtobufUtil.toDelete(m, cells); > batchContainsDelete =3D true; > } > mutationActionMap.put(mutation, action); > mArray[i++] =3D mutation; > checkCellSizeLimit(region, mutation); > // Check if a space quota disallows this mutation > spaceQuotaEnforcement.getPolicyEnforcement(region).check(mutation= ); > quota.addMutation(mutation); > } > {code} > rs has caught the exception but it doesn't have the cellscanner skip the = failed cells. > {code:java} > } catch (IOException ie) { > if (atomic) { > throw ie; > } > for (Action mutation : mutations) { > builder.addResultOrException(getResultOrException(ie, mutation.ge= tIndex())); > } > } > {code} > The bug results in the WrongRowIOException to remaining mutations since t= hey=C2=A0refer to invalid cells. -- This message was sent by Atlassian JIRA (v7.6.3#76005)