hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-19985) Redundant instanceof check in ProtobufUtil#getServiceException
Date Wed, 14 Feb 2018 13:04:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chia-Ping Tsai updated HBASE-19985:
-----------------------------------
    Labels:   (was: be)

> Redundant instanceof check in ProtobufUtil#getServiceException
> --------------------------------------------------------------
>
>                 Key: HBASE-19985
>                 URL: https://issues.apache.org/jira/browse/HBASE-19985
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Ted Yu
>            Priority: Trivial
>
> {code}
>   public static IOException getServiceException(ServiceException e) {
>     Throwable t = e;
>     if (e instanceof ServiceException) {
>       t = e.getCause();
> {code}
> The instanceof check would always return true.
> This was reported by https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message