hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
Date Mon, 12 Feb 2018 10:10:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360544#comment-16360544
] 

Duo Zhang commented on HBASE-19972:
-----------------------------------

Ping [~apurtell]. I think this is very critical bug which may cause inconsistency if you use
replication. Do you think we should make a 1.4.x release ASAP? Maybe 1.4.1.1?

Thanks.

> Should rethrow  the RetriesExhaustedWithDetailsException when failed to apply the batch
in ReplicationSink
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19972
>                 URL: https://issues.apache.org/jira/browse/HBASE-19972
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Critical
>             Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
>         Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch, HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091. 
> In ReplicationSink#batch,we swallow the RetriesExhaustedWithDetailsException except 
> TableNotFoundException,   actually,  should rethrow the exception. 
> {code:java}
> try {
>       Connection connection = getConnection();
>       table = connection.getTable(tableName);
>       for (List<Row> rows : allRows) {
>         table.batch(rows);
>       }
>     } catch (RetriesExhaustedWithDetailsException rewde) {
>       for (Throwable ex : rewde.getCauses()) {
>         if (ex instanceof TableNotFoundException) {
>           throw new TableNotFoundException("'"+tableName+"'");
>         }
>       }
>     } 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message