hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19954) ShutdownHook should check whether shutdown hook is tracked by ShutdownHookManager
Date Tue, 20 Feb 2018 00:19:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369611#comment-16369611
] 

Ted Yu commented on HBASE-19954:
--------------------------------

Patch v2 adds audience annotation for the ShutdownHookManager class.

hasShutdownHook() is exercised by the TestBlockReorder against hadoop3.

If specific scenario is desired to test hasShutdownHook(), let me know.

> ShutdownHook should check whether shutdown hook is tracked by ShutdownHookManager
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-19954
>                 URL: https://issues.apache.org/jira/browse/HBASE-19954
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>         Attachments: 19954.v1.txt, 19954.v2.txt
>
>
> Currently ShutdownHook#suppressHdfsShutdownHook() does the following:
> {code}
>       synchronized (fsShutdownHooks) {
>         boolean isFSCacheDisabled = fs.getConf().getBoolean("fs.hdfs.impl.disable.cache",
false);
>         if (!isFSCacheDisabled && !fsShutdownHooks.containsKey(hdfsClientFinalizer)
>             && !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer))
{
> {code}
> There is no check that ShutdownHookManager still tracks the shutdown hook, leading to
potential RuntimeException (as can be observed in hadoop3 Jenkins job).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message