hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19953) Avoid calling post* hook when procedure fails
Date Wed, 14 Feb 2018 20:22:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364707#comment-16364707
] 

Josh Elser commented on HBASE-19953:
------------------------------------

Mighty [~stack]: one more (basic?) question for you. I'm seeing some discrepancies between
CreateTableProcedure and DeleteNamespaceProcedure in how 'pre-checks' are handled. Specifically
the difference between {{CreateTableProcedure#prepareCreate(..)}} and {{DeleteNamespaceProcedure#prepareDelete(..)}}.
The former calls {{setFailure(..)}} with exceptions that would prevent a table-creation from
happening (e.g. table already exists) while the latter just throws the Exception.

Are these logically equivalent at a higher level? Or is this a sign that DeleteNS needs to
be updated?

> Avoid calling post* hook when procedure fails
> ---------------------------------------------
>
>                 Key: HBASE-19953
>                 URL: https://issues.apache.org/jira/browse/HBASE-19953
>             Project: HBase
>          Issue Type: Bug
>          Components: master, proc-v2
>            Reporter: Ramesh Mani
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>
> Ramesh pointed out a case where I think we're mishandling some post\* MasterObserver
hooks. Specifically, I'm looking at the deleteNamespace.
> We synchronously execute the DeleteNamespace procedure. When the user provides a namespace
that isn't empty, the procedure does a rollback (which is just a no-op), but this doesn't
propagate an exception up to the NonceProcedureRunnable in {{HMaster#deleteNamespace}}. It
took Ramesh pointing it out a bit better to me that the code executes a bit differently than
we actually expect.
> I think we need to double-check our post hooks and make sure we aren't invoking them
when the procedure actually failed. cc/ [~Apache9], [~stack].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message