hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19930) fix ImmutableMemStoreLAB#forceCopyOfBigCellInto
Date Fri, 09 Feb 2018 04:35:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357908#comment-16357908
] 

Anoop Sam John commented on HBASE-19930:
----------------------------------------

Oh if that is the case yes.  But we need some fat comments for this. Why we do ..  This is
an Immutable MSLAB but we allow the force copy ti happen. And the normal copy op throw Unsupported
exception..  Pls add enough comments.  Also the copy is to 0th offset MSLAB.. this looks fine
as to which the copy happens, does not matter.  Pls add enough comments. 

> fix ImmutableMemStoreLAB#forceCopyOfBigCellInto
> -----------------------------------------------
>
>                 Key: HBASE-19930
>                 URL: https://issues.apache.org/jira/browse/HBASE-19930
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Gali Sheffi
>            Assignee: Gali Sheffi
>            Priority: Major
>         Attachments: HBASE-19930-V01.patch, HBASE-19930-V02.patch, HBASE-19930-V03.patch,
HBASE-19930-V04.patch
>
>
> This issue is about fixing ImmutableMemStoreLAB#forceCopyOfBigCellInto.
> Following a comment in HBASE-19133 regarding a bug in ImmutableMemStoreLAB#forceCopyOfBigCellInto
(assuming this method is never called for an ImmutableMemStoreLAB, and just throwing an IllegalStateException
whenever called), the forceCopyOfBigCellInto method now performs the copy of big cells on
the first MSLABImpl in its mslabs linked-list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message