hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "huaxiang sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19924) hbase rpc throttling does not work for multi() with request count rater.
Date Wed, 07 Feb 2018 01:00:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354809#comment-16354809
] 

huaxiang sun commented on HBASE-19924:
--------------------------------------

Upload v1 patch.

> hbase rpc throttling does not work for multi() with request count rater.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-19924
>                 URL: https://issues.apache.org/jira/browse/HBASE-19924
>             Project: HBase
>          Issue Type: Bug
>          Components: rpc
>    Affects Versions: 1.2.6, 2.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Major
>         Attachments: HBASE-19924-master-v001.patch
>
>
> Basically, rpc throttling does not work for request count based rater for multi. for
the following code, when it calls limiter's checkQuota(), numWrites/numReads is lost.
> {code:java}
> @Override
> public void checkQuota(int numWrites, int numReads, int numScans) throws ThrottlingException
{
>   writeConsumed = estimateConsume(OperationType.MUTATE, numWrites, 100);
>   readConsumed = estimateConsume(OperationType.GET, numReads, 100);
>   readConsumed += estimateConsume(OperationType.SCAN, numScans, 1000);
>   writeAvailable = Long.MAX_VALUE;
>   readAvailable = Long.MAX_VALUE;
>   for (final QuotaLimiter limiter : limiters) {
>     if (limiter.isBypass()) continue;
>     limiter.checkQuota(writeConsumed, readConsumed);
>     readAvailable = Math.min(readAvailable, limiter.getReadAvailable());
>     writeAvailable = Math.min(writeAvailable, limiter.getWriteAvailable());
>   }
>   for (final QuotaLimiter limiter : limiters) {
>     limiter.grabQuota(writeConsumed, readConsumed);
>   }
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message