hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19920) TokenUtil.obtainToken unnecessarily creates a local directory
Date Tue, 06 Feb 2018 00:40:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353157#comment-16353157
] 

Ted Yu commented on HBASE-19920:
--------------------------------

Looks good overall.
{code}
+   * @return IOException wrapped in ServiceException.
{code}
The above is backwards, right (ServiceException wrapped in IOException) ?
{code}
+      TokenUtil.obtainToken(null);
+    } catch (Exception e) {
{code}
Since exception is expected, you can add assert(false) following TokenUtil.obtainToken() in
the try block.

> TokenUtil.obtainToken unnecessarily creates a local directory
> -------------------------------------------------------------
>
>                 Key: HBASE-19920
>                 URL: https://issues.apache.org/jira/browse/HBASE-19920
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: 2.0
>
>         Attachments: HBASE-19920.patch, HBASE-19920.v2.patch, HBASE-19920.v3.patch
>
>
> On client code, when one calls TokenUtil.obtainToken it loads ProtobufUtil which in its
static block initializes DynamicClassLoader and that creates the directory ${hbase.local.dir}/jars/
and also instantiates a filesystem class to access hbase.dynamic.jars.dir.
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java#L109-L127
> Since this is region server specific code, not expecting this to happen when one accesses
hbase as a client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message