hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19920) TokenUtil.obtainToken unnecessarily creates a local directory
Date Mon, 05 Feb 2018 19:03:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352775#comment-16352775
] 

Mike Drob commented on HBASE-19920:
-----------------------------------

Ah, I think I misunderstood your question earlier. It's a good point about the statically
referenced classes and needing to set the thread CL. I wasn't thinking in that direction.
The CPEP example doesn't fit here.

That said, clients using ProtobufUtil::toException, ::toComparator, and ::toFilter still might
have reason to need the dynamic jars. Not sure how prevalent this is.

> TokenUtil.obtainToken unnecessarily creates a local directory
> -------------------------------------------------------------
>
>                 Key: HBASE-19920
>                 URL: https://issues.apache.org/jira/browse/HBASE-19920
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: 2.0
>
>         Attachments: HBASE-19920.patch
>
>
> On client code, when one calls TokenUtil.obtainToken it loads ProtobufUtil which in its
static block initializes DynamicClassLoader and that creates the directory ${hbase.local.dir}/jars/
and also instantiates a filesystem class to access hbase.dynamic.jars.dir.
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java#L109-L127
> Since this is region server specific code, not expecting this to happen when one accesses
hbase as a client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message