hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohini Palaniswamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19920) TokenUtil.obtainToken unnecessarily creates a local directory
Date Fri, 02 Feb 2018 22:04:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350991#comment-16350991
] 

Rohini Palaniswamy commented on HBASE-19920:
--------------------------------------------

bq. Do you want to submit a patch ?
No

>From my perspective, a call to get delegation token should not be 
   1) Creating a local directory
   2) Instantiating a filesystem class be it local or remote. It is worse when it is remote
because of the overhead involved with instantiating a DFSClient (opening sockets, etc).

I do not have a problem if DynamicClassLoader actually does those things when the client intends
to use coprocessors. Would just prefer it to be taken out of the code path of getting delegation
tokens.



> TokenUtil.obtainToken unnecessarily creates a local directory
> -------------------------------------------------------------
>
>                 Key: HBASE-19920
>                 URL: https://issues.apache.org/jira/browse/HBASE-19920
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>            Priority: Major
>
> On client code, when one calls TokenUtil.obtainToken it loads ProtobufUtil which in its
static block initializes DynamicClassLoader and that creates the directory ${hbase.rootdir}/lib
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java#L115-L127
> Since this is region server specific code, not expecting this to happen when one accesses
hbase as a client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message