From issues-return-331503-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Tue Jan 30 13:23:32 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id A344818061A for ; Tue, 30 Jan 2018 13:23:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 92F39160C53; Tue, 30 Jan 2018 12:23:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D7216160C42 for ; Tue, 30 Jan 2018 13:23:31 +0100 (CET) Received: (qmail 28589 invoked by uid 500); 30 Jan 2018 12:23:30 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 28578 invoked by uid 99); 30 Jan 2018 12:23:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jan 2018 12:23:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 59B4218034D for ; Tue, 30 Jan 2018 12:23:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id weaRiAZCwg4D for ; Tue, 30 Jan 2018 12:23:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C9C9061387 for ; Tue, 30 Jan 2018 12:17:17 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ED043E00D2 for ; Tue, 30 Jan 2018 12:17:16 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6C418212FC for ; Tue, 30 Jan 2018 12:17:01 +0000 (UTC) Date: Tue, 30 Jan 2018 12:17:00 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-19826) Provide a option to see rows behind a delete in a time range queries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-19826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344966#comment-16344966 ] Duo Zhang commented on HBASE-19826: ----------------------------------- {quote} JDBC is always the first choice when using Phoenix but some people are writing the table using HBase API and querying through Phoenix till they migrate their legacy application. {quote} HBase-2.0 is a big release that breaks things, so I think it may also be a good chance for Phoenix to drop some legacy support when upgrading to HBase-2.0? > Provide a option to see rows behind a delete in a time range queries > -------------------------------------------------------------------- > > Key: HBASE-19826 > URL: https://issues.apache.org/jira/browse/HBASE-19826 > Project: HBase > Issue Type: Improvement > Reporter: Ankit Singhal > Assignee: Ankit Singhal > Priority: Major > Fix For: 2.0.0 > > > We can provide an option (something like seePastDeleteMarkers) in a scan to let the user see the versions behind the delete marker even if keepDeletedCells is set to false in the descriptor. > With the previous version, we workaround the same in preStoreScannerOpen hook. For reference PHOENIX-4277 > {code} > @Override > public KeyValueScanner preStoreScannerOpen(final ObserverContext c, > final Store store, final Scan scan, final NavigableSet targetCols, > final KeyValueScanner s) throws IOException { > > if (scan.isRaw() || ScanInfoUtil.isKeepDeletedCells(store.getScanInfo()) || scan.getTimeRange().getMax() == HConstants.LATEST_TIMESTAMP || TransactionUtil.isTransactionalTimestamp(scan.getTimeRange().getMax())) { > return s; > } > > ScanInfo scanInfo = ScanInfoUtil.cloneScanInfoWithKeepDeletedCells(store.getScanInfo()); > return new StoreScanner(store, scanInfo, scan, targetCols, > c.getEnvironment().getRegion().getReadpoint(scan.getIsolationLevel())); > } > {code} > Another way is to provide a way to set KEEP_DELETED_CELLS to true in ScanOptions of preStoreScannerOpen. -- This message was sent by Atlassian JIRA (v7.6.3#76005)