From issues-return-329734-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Mon Jan 15 08:19:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 46C5E180657 for ; Mon, 15 Jan 2018 08:19:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 370B4160C31; Mon, 15 Jan 2018 07:19:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 79B67160C25 for ; Mon, 15 Jan 2018 08:19:05 +0100 (CET) Received: (qmail 74551 invoked by uid 500); 15 Jan 2018 07:19:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 74540 invoked by uid 99); 15 Jan 2018 07:19:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jan 2018 07:19:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2901518068E for ; Mon, 15 Jan 2018 07:19:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.711 X-Spam-Level: X-Spam-Status: No, score=-108.711 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LNQFO2hQyjMe for ; Mon, 15 Jan 2018 07:19:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 32ACE5FAC2 for ; Mon, 15 Jan 2018 07:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E962E05D7 for ; Mon, 15 Jan 2018 07:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2A41E212FE for ; Mon, 15 Jan 2018 07:19:00 +0000 (UTC) Date: Mon, 15 Jan 2018 07:19:00 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-19797) Operator priority leads to wrong logic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Duo Zhang created HBASE-19797: --------------------------------- Summary: Operator priority leads to wrong logic Key: HBASE-19797 URL: https://issues.apache.org/jira/browse/HBASE-19797 Project: HBase Issue Type: Bug Environment: {code} if (e instanceof EOFException || e.getCause() instanceof EOFException && logQueue.size() > 1 && this.eofAutoRecovery) {code} https://docs.oracle.com/javase/tutorial/java/nutsandbolts/operators.html According to the doc here, && has a higher priority than ||, so we will only check logQueueSize when e.getCause is an EOFException, which is incorrect. Reporter: Duo Zhang -- This message was sent by Atlassian JIRA (v7.6.3#76005)