From issues-return-328301-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Sat Jan 6 00:18:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5109C180647 for ; Sat, 6 Jan 2018 00:18:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 408B5160C28; Fri, 5 Jan 2018 23:18:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85C91160C27 for ; Sat, 6 Jan 2018 00:18:05 +0100 (CET) Received: (qmail 3060 invoked by uid 500); 5 Jan 2018 23:18:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 3047 invoked by uid 99); 5 Jan 2018 23:18:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 23:18:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 004BFC357A for ; Fri, 5 Jan 2018 23:18:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sn4GGJa81CVf for ; Fri, 5 Jan 2018 23:18:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E4FC55FB3E for ; Fri, 5 Jan 2018 23:18:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6023CE0F61 for ; Fri, 5 Jan 2018 23:18:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D956B240F6 for ; Fri, 5 Jan 2018 23:18:01 +0000 (UTC) Date: Fri, 5 Jan 2018 23:18:01 +0000 (UTC) From: "Josh Elser (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-19709) Guard against a ThreadPool size of 0 in CleanerChore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-19709?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 14109#comment-16314109 ]=20 Josh Elser commented on HBASE-19709: ------------------------------------ {quote} [WARNING] Tests run: 3311, Failures: 0, Errors: 0, Skipped: 33 {quote} Seems like the runner died at the end? I think I'm OK to push this. > Guard against a ThreadPool size of 0 in CleanerChore > ---------------------------------------------------- > > Key: HBASE-19709 > URL: https://issues.apache.org/jira/browse/HBASE-19709 > Project: HBase > Issue Type: Bug > Reporter: Siddharth Wagle > Assignee: Josh Elser > Priority: Critical > Fix For: 3.0.0, 2.0.0-beta-2 > > Attachments: HBASE-19709.001.branch-2.patch, HBASE-19709.002.bran= ch-2.patch > > > Post HBASE-18309, we choose the number of threads by the following logic: > {code} > + /** > + * If it is an integer and >=3D 1, it would be the size; > + * if 0.0 < size <=3D 1.0, size would be available processors * size. > + * Pay attention that 1.0 is different from 1, former indicates it wil= l use 100% of cores, > + * while latter will use only 1 thread for chore to scan dir. > + */ > {code} > [~swagle] has found on his VM that despite having two virtual processors,= {{Runtime.getRuntime().availableProcessors()}} returns 0, which results in= 0 threads for the pool which throws an exception. > {noformat} > java.lang.IllegalArgumentException > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t java.util.concurrent.ForkJoinPool.checkParallelism(ForkJoinPool.java:2546= ) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t java.util.concurrent.ForkJoinPool.(ForkJoinPool.java:2536) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t java.util.concurrent.ForkJoinPool.(ForkJoinPool.java:2505) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t org.apache.hadoop.hbase.master.cleaner.CleanerChore.(CleanerChore.j= ava:112) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t org.apache.hadoop.hbase.master.cleaner.CleanerChore.(CleanerChore.j= ava:83) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t org.apache.hadoop.hbase.master.cleaner.LogCleaner.(LogCleaner.java:= 65) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t org.apache.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1= 130) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(H= Master.java:813) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t org.apache.hadoop.hbase.master.HMaster.access$500(HMaster.java:223) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2016) > =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82a= t java.lang.Thread.run(Thread.java:745) > {noformat} > We should make sure that we take the max of {{1}} and the computed number= of threads. -- This message was sent by Atlassian JIRA (v6.4.14#64029)