Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 3 Jan 2018 01:42:00 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13127792.1514689969000.560338.1514943720788@Atlassian.JIRA>
In-Reply-To: <JIRA.13127792.1514689969000@Atlassian.JIRA>
References: <JIRA.13127792.1514689969000@Atlassian.JIRA> <JIRA.13127792.1514689969630@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-19675) Miscellaneous HStore Class
 Improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 03 Jan 2018 01:42:08 -0000


    [ https://issues.apache.org/jira/browse/HBASE-19675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308999#comment-16308999 ] 

Hudson commented on HBASE-19675:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4333 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4333/])
HBASE-19675 Miscellaneous HStore Class Improvements. (appy: rev a47afc84cd17e1c01a20760cb3b007ca9afa5d35)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java


> Miscellaneous HStore Class Improvements
> ---------------------------------------
>
>                 Key: HBASE-19675
>                 URL: https://issues.apache.org/jira/browse/HBASE-19675
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbase
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19675.1.patch, HBASE-19675.2.patch
>
>
> * Remove logging code guards in favor of slf4j parameters
> * Use {{CollectionsUtils.isEmpty()}} consistently
> * Small check-style fixes
> * Remove flow control logic from {{trace}} statement {code}          if (LOG.isTraceEnabled()) {
>             LOG.trace("No compacted files to archive");
>             return;
>           }{code}
> * Replace two calls to the same getter to ensure that the value doesn't change between calls {code}      if (getCompactedFiles() != null) {
>         for (HStoreFile file : getCompactedFiles()) {
>           name2File.put(file.getFileInfo().getActiveFileName(), file);
>         }
>       }{code}
> * Make 'inputFiles' a Set for fast calls to {{contains}} method instead {code}    //some of the input files might already be deleted
>     List<HStoreFile> inputStoreFiles = new ArrayList<>(compactionInputs.size());
>     for (HStoreFile sf : this.getStorefiles()) {
>       if (inputFiles.contains(sf.getPath().getName())) {
>         inputStoreFiles.add(sf);
>       }
>     }{code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)