hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19770) Add '--return-values' option to Shell to print return values of commands in interactive mode
Date Tue, 16 Jan 2018 19:59:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327693#comment-16327693
] 

Mike Drob commented on HBASE-19770:
-----------------------------------

btw, you don't need the return keyword and you especially don't need {{return nil}}.

Assuming, I got the condition correctly, this should work for you:
{code}
    def command(command, *args)
      ret = internal_command(command, :command, *args)
      ret if return_values or not interactive
    end
{code}

> Add '--return-values' option to Shell to print return values of commands in interactive
mode
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19770
>                 URL: https://issues.apache.org/jira/browse/HBASE-19770
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Romil Choksi
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19770.001.branch-2.patch, HBASE-19770.002.branch-2.patch
>
>
> Another good find by our Romil.
> {code}
> hbase(main):001:0> list
> TABLE
> a
> 1 row(s)
> Took 0.8385 seconds
> hbase(main):002:0> tables=list
> TABLE
> a
> 1 row(s)
> Took 0.0267 seconds
> hbase(main):003:0> puts tables
> hbase(main):004:0> p tables
> nil
> {code}
> The {{list}} command should be returning {{\['a'\]}} but is not.
> The command class itself appears to be doing the right thing -- maybe the retval is getting
lost somewhere else?
> FYI [~stack].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message