hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Soldatov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19746) Add default impl to Cell#getType
Date Wed, 10 Jan 2018 23:10:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321315#comment-16321315
] 

Sergey Soldatov commented on HBASE-19746:
-----------------------------------------

My concern is whether it's reasonable to use functional stuff here (Stream plus filters).
Quick benchmarks results:
{noformat}
MyBenchmark.testUsingExtendedCellGetType  avgt   15   1.074 ± 0.030  ns/op
MyBenchmark.testUsingKeyValueGetType      avgt   15   0.620 ± 0.019  ns/op
MyBenchmark.testUsingNewGetType           avgt   15  44.002 ± 1.690  ns/op
{noformat}
As we can see functional version is 40 times slower than the one we have in ExtendedCell and
almost 70 times slower than the original version that we have in KeyValue. 

> Add default impl to Cell#getType
> --------------------------------
>
>                 Key: HBASE-19746
>                 URL: https://issues.apache.org/jira/browse/HBASE-19746
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-19746.v0.patch
>
>
> Noticed this issue when migrating the app to branch-2.
> {{Cell}} is IA.Public so it should obey our compatibility rules. Not sure whether any
related discussion had be in HBASE-19112. It worthwhile, however, to raise this issue again.
> FYI [~anoopsamjohn] [~ram_krish] [~stack]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message