hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19731) TestFromClientSide#testCheckAndDeleteWithCompareOp and testNullQualifier are flakey
Date Mon, 08 Jan 2018 18:24:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316734#comment-16316734
] 

stack commented on HBASE-19731:
-------------------------------

Patch fixes the test for sure. +1.

On making this test timestamper default, we can't, right? Proper fix is HLC. Failing that,
a timestamper like that in patch would be a limit of about 1k ops a second? And the checkAndSet
for time is costly? We'd have to be parsimonious about checking time (currently we do it all
over the code base w/o regard for cost).

It looks like the test fails in same place in alpha-4 so my thought that it new to beta-1
doesn't hold. Makes sense. I don't see it in the general flakies list: https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html
 probably because apache jenkins is slow overall... slower than my local machine or JMS's
(or yours).

Thanks for jumping in here [~Apache9] and confirming speculation on root issue (would have
taken me way longer to figure...)



> TestFromClientSide#testCheckAndDeleteWithCompareOp and testNullQualifier are flakey
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-19731
>                 URL: https://issues.apache.org/jira/browse/HBASE-19731
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19731.patch
>
>
> These two tests fail frequently locally; rare does this suite pass.
> The failures are either of these two tests.  Unfortunately, running the test standalone
does not bring  on the issue; need to run the whole suite.
> In both cases, we have a Delete followed by a Put and then a checkAnd* -type operation
which does a Get expecting to find the just put Put but it fails on occasion.
> Looks to be an mvcc issues or Put going in at same timestamp as the Delete. Its hard
to debug given any added logging seems to make it all pass again.
> Seems this too is new in beta-1. Running tests against alpha-4 seem to pass.
> Doing a compare....



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message