hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yung-An He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19607) throw the exception if memstore is incompetent to do the deep clone for cell
Date Fri, 12 Jan 2018 05:40:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323572#comment-16323572
] 

Yung-An He commented on HBASE-19607:
------------------------------------

HBaseIOE +1 .

I would use HBaseIOE instead of IOE.

Is it necessary to create a new issue to fix setSequenceId and change the Exception type from
IOException to HBaseIOE?

> throw the exception if memstore is incompetent to do the deep clone for cell
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-19607
>                 URL: https://issues.apache.org/jira/browse/HBASE-19607
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Yung-An He
>            Priority: Trivial
>
> We must to clone the cell since the cell is backed by the reusable byte array. Also,
we assume all cells passed to AbstractMemStore is of ExtendedCell. Not only is the type check
unnecessary, but it also confuses the readers. 
> {code:title=AbstractMemStore.java}
>   private static Cell deepCopyIfNeeded(Cell cell) {
>     if (cell instanceof ExtendedCell) {
>       return ((ExtendedCell) cell).deepClone();
>     }
>     return cell;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message