Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 30 Dec 2017 08:59:00 +0000 (UTC)
From: "Xiang Li (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13127743.1514616302000.549055.1514624340090@Atlassian.JIRA>
In-Reply-To: <JIRA.13127743.1514616302000@Atlassian.JIRA>
References: <JIRA.13127743.1514616302000@Atlassian.JIRA> <JIRA.13127743.1514616302552@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-19672) Correct comments for default values
 of major compaction in SortedCompactionPolicy#getNextMajorCompactTime()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sat, 30 Dec 2017 08:59:04 -0000


     [ https://issues.apache.org/jira/browse/HBASE-19672?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiang Li updated HBASE-19672:
-----------------------------
    Status: Open  (was: Patch Available)

> Correct comments for default values of major compaction in SortedCompacti=
onPolicy#getNextMajorCompactTime()
> -------------------------------------------------------------------------=
----------------------------------
>
>                 Key: HBASE-19672
>                 URL: https://issues.apache.org/jira/browse/HBASE-19672
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>         Attachments: HBASE-19672.master.000.patch
>
>
> {code:title=3Dhbase-server/src/main/java/org/apache/hadoop/hbase/regionse=
rver/compactions/SortedCompactionPolicy.java|borderStyle=3Dsolid}
> public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact=
) {
> {
>     // default =3D 24hrs
>    long period =3D comConf.getMajorCompactionPeriod();
>     ...
>     // default =3D 20% =3D +/- 4.8 hrs
>     double jitterPct =3D comConf.getMajorCompactionJitter();
>     ...
> }
> {code}
> If I get it correctly, currently, default major compaction period is 7 da=
ys=EF=BC=8Cand jitter is 0.5, so 3.5 days.
> We could either remove those comments, or add \{@link\} to link to the de=
fault value definitions.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)