Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 24 Dec 2017 02:23:00 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13125633.1513605335000.526535.1514082180053@Atlassian.JIRA>
In-Reply-To: <JIRA.13125633.1513605335000@Atlassian.JIRA>
References: <JIRA.13125633.1513605335000@Atlassian.JIRA> <JIRA.13125633.1513605335246@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-19550) Wrap the Mutation in cp layer to
 make sure all passed cells are of ExtendedCell
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 24 Dec 2017 02:23:08 -0000


    [ https://issues.apache.org/jira/browse/HBASE-19550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302641#comment-16302641 ] 

Ted Yu commented on HBASE-19550:
--------------------------------

Looks good overall.
Minor comments below.
{code}
+    } catch (IOException e) {
+      // we eat the exception of wrong row for BC..
{code}
Should the IOE be logged ?
In Mutation :
{code}
+  Mutation add(Cell cell) throws IOException {
+    //Checking that the row of the kv is the same as the put
{code}
'put' is not accurate, right ?
{code}
+  private static final class CellWrap implements ExtendedCell {
{code}
CellWrap -> CellWrapper
{code}
+    public Optional<Tag> getTag(byte type) {
{code}
The implementation is similar to PrivateCellUtil#getTag(). Is it possible to refactor the code ?


> Wrap the Mutation in cp layer to make sure all passed cells are of ExtendedCell
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-19550
>                 URL: https://issues.apache.org/jira/browse/HBASE-19550
>             Project: HBase
>          Issue Type: Task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19550.v0.patch
>
>
> We assume all cells in server are of ExtendedCell. However, cp user can add their cell impl via Put#add(Cell) in observer. That will cause UnsupportedOperationException when rs try to update the cell's timestamp and seq Id. We should do something for cp user...For example, wrap the passed cells to be a extendcell type.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)