Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 5 Dec 2017 23:58:00 +0000 (UTC)
From: "Chia-Ping Tsai (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13120584.1511510198000.393876.1512518280144@Atlassian.JIRA>
In-Reply-To: <JIRA.13120584.1511510198000@Atlassian.JIRA>
References: <JIRA.13120584.1511510198000@Atlassian.JIRA> <JIRA.13120584.1511510198606@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY
 cann't be set directly by hbase shell
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 05 Dec 2017 23:58:11 -0000


    [ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279399#comment-16279399 ] 

Chia-Ping Tsai commented on HBASE-19340:
----------------------------------------

bq. I learned from HBASE-17736 and I found you have already add configuration such as split_policy and flush_policy in admin.create() method. I think maybe we should add the same logic in admin.alter() method or I missed the code 
Parsing the option is implemented in {{update_htd_from_arg}} which is used by admin.create and admin.alter. The admin.rb has a bit changes between branch-1.4+ and branch-1.2/1.3. see HBASE-15845

bq. Please help me to review this patch If it is convenient for you.
The patch LGTM. Do you want to backport all missed options here?

> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> -------------------------------------------------------------------
>
>                 Key: HBASE-19340
>                 URL: https://issues.apache.org/jira/browse/HBASE-19340
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.6
>            Reporter: zhaoyuan
>            Assignee: zhaoyuan
>             Fix For: 1.2.8
>
>         Attachments: HBASE-19340-branch-1.2.batch
>
>
> Recently I wanna try to alter the split policy for a table on my cluster which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute of the HTable so I run the command in hbase shell console below. 
> alter 'tablex',SPLIT_POLICY => 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy'
> However, It gave the information like this and I confused 
> Unknown argument ignored: SPLIT_POLICY
> Updating all regions with the new schema...
> So I check the source code That admin.rb might miss the setting for this argument .
> htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if arg[MAX_FILESIZE]
> htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY]
> ...
> So I think it may be a bug  ,is it?


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)