hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19672) Correct comments for default values of major compaction in SortedCompactionPolicy#getNextMajorCompactTime()
Date Sun, 31 Dec 2017 01:42:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307031#comment-16307031
] 

Hudson commented on HBASE-19672:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4315 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4315/])
HBASE-19672 Correct comments for default values of major compaction in (tedyu: rev 0cd6050d090d11240a40c012716b3d747fbcb58f)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java


> Correct comments for default values of major compaction in SortedCompactionPolicy#getNextMajorCompactTime()
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19672
>                 URL: https://issues.apache.org/jira/browse/HBASE-19672
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19672.master.000.patch, HBASE-19672.master.001.patch, HBASE-19672.master.002.patch
>
>
> {code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java|borderStyle=solid}
> public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact) {
> {
>     // default = 24hrs
>    long period = comConf.getMajorCompactionPeriod();
>     ...
>     // default = 20% = +/- 4.8 hrs
>     double jitterPct = comConf.getMajorCompactionJitter();
>     ...
> }
> {code}
> If I get it correctly, currently, default major compaction period is 7 days´╝îand jitter
is 0.5, so 3.5 days.
> We could either remove those comments, or add \{@link\} to link to the default value
definitions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message