hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiang Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-19672) Correct comments in SortedCompactionPolicy#getNextMajorCompactTime()
Date Sat, 30 Dec 2017 06:52:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Xiang Li updated HBASE-19672:
-----------------------------
    Description: 
{code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java|borderStyle=solid}
public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact) {
{
    // default = 24hrs
   long period = comConf.getMajorCompactionPeriod();
    ...
    // default = 20% = +/- 4.8 hrs
    double jitterPct = comConf.getMajorCompactionJitter();
    ...
}
{code}
If I get it correctly, currently, default major compaction period is 7 days and jitter is
0.5, that 3.5 days.
{noforamt} We could either remove those comments, or add {@link} to link to the default value
definitions.{noforamt}

  was:
{code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java|borderStyle=solid}
public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact) {
{
    // default = 24hrs
   long period = comConf.getMajorCompactionPeriod();
    ...
    // default = 20% = +/- 4.8 hrs
    double jitterPct = comConf.getMajorCompactionJitter();
    ...
}
{code}
If I get it correctly, currently, default major compaction period is 7 days and jitter is
0.5, that 3.5 days.
We could either remove those comments, or add {@link} to link to the default value definitions.


> Correct comments in SortedCompactionPolicy#getNextMajorCompactTime()
> --------------------------------------------------------------------
>
>                 Key: HBASE-19672
>                 URL: https://issues.apache.org/jira/browse/HBASE-19672
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Xiang Li
>            Priority: Minor
>
> {code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java|borderStyle=solid}
> public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact) {
> {
>     // default = 24hrs
>    long period = comConf.getMajorCompactionPeriod();
>     ...
>     // default = 20% = +/- 4.8 hrs
>     double jitterPct = comConf.getMajorCompactionJitter();
>     ...
> }
> {code}
> If I get it correctly, currently, default major compaction period is 7 days and jitter
is 0.5, that 3.5 days.
> {noforamt} We could either remove those comments, or add {@link} to link to the default
value definitions.{noforamt}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message