hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balazs Meszaros (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19598) Fix TestAssignmentManagerMetrics flaky test
Date Fri, 22 Dec 2017 14:16:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301493#comment-16301493
] 

Balazs Meszaros edited comment on HBASE-19598 at 12/22/17 2:15 PM:
-------------------------------------------------------------------

[~stack] why was this change in {{ServerManager}}?

{code:java}
public void shutdownCluster() {
  String statusStr = "Cluster shutdown requested of master=" + this.master.getServerName();
  LOG.info(statusStr);
  this.clusterShutdown.set(true);
  this.master.stop(statusStr); // <-- THIS LINE WAS REMOVED
}
{code}

If I put it back, the test passes.


was (Author: balazs.meszaros):
[~stack] why was this change?

{code:java}
public void shutdownCluster() {
  String statusStr = "Cluster shutdown requested of master=" + this.master.getServerName();
  LOG.info(statusStr);
  this.clusterShutdown.set(true);
  this.master.stop(statusStr); // <-- THIS LINE WAS REMOVED
}
{code}

If I put it back, the test passes.

> Fix TestAssignmentManagerMetrics flaky test
> -------------------------------------------
>
>                 Key: HBASE-19598
>                 URL: https://issues.apache.org/jira/browse/HBASE-19598
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Balazs Meszaros
>            Assignee: Balazs Meszaros
>
> TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that commit
010012cbcb broke it (HBASE-18946).
> The test method runs successfully, but it cannot shut the minicluster down, and hangs
forever.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message