hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Somogyi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19565) TestSafemodeBringsDownMaster constantly hangs
Date Wed, 20 Dec 2017 11:33:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298320#comment-16298320
] 

Peter Somogyi commented on HBASE-19565:
---------------------------------------

FanOutOneBlockAsyncDFSOutputHelper#completeFile method also needs modification to catch SafeModeException.
{code}
      try {
        if (namenode.complete(src, clientName, block, fileId)) {
          endFileLease(client, fileId);
          return;
        } else {
          LOG.warn("complete file " + src + " not finished, retry = " + retry);
        }
      } catch (RemoteException e) {
        IOException ioe = e.unwrapRemoteException();
        if (ioe instanceof LeaseExpiredException) {
          LOG.warn("lease for file " + src + " is expired, give up", e);
          return;
        } else if (ioe instanceof SafeModeException) {  // here we have to catch SafeModeException
          return;
        } else {
          LOG.warn("complete file " + src + " failed, retry = " + retry, e);
        }
      } catch (Exception e) {
        LOG.warn("complete file " + src + " failed, retry = " + retry, e);
      }
      sleepIgnoreInterrupt(retry);

{code}

> TestSafemodeBringsDownMaster constantly hangs
> ---------------------------------------------
>
>                 Key: HBASE-19565
>                 URL: https://issues.apache.org/jira/browse/HBASE-19565
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha-4
>            Reporter: Peter Somogyi
>            Assignee: Peter Somogyi
>             Fix For: 2.0.0-beta-2
>
>
> TestSafemodeBringsDownMaster always hangs. The problem is with HDFS dependency:
> SafeMode is turned on for HDFS which will throw SafeModeException. FanOutOneBlockAsyncDFSOutputHelper#completeFile
should catch that exception but when unwrapRemoteException() is called NoSuchMethodError is
thrown because SafeMode does not have constructor with String parameter in 2.7.4 release.
> This was fixed by HDFS-8592 but it is not part of 2.7 release line since it is a breaking
change.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message