hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Toshihiro Suzuki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19551) hbck -boundaries doesn't work correctly
Date Tue, 19 Dec 2017 15:20:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296946#comment-16296946
] 

Toshihiro Suzuki commented on HBASE-19551:
------------------------------------------

Thank you [~tedyu]. 

{quote}
Is it possible to verify this fix in cluster ?
{quote}

Actually, I reproduced the issue in my local env and it looked like the patch resolved the
issue. I think it is not easy to write unit test code as we have to reproduce boundary inconsistency.

> hbck -boundaries doesn't work correctly
> ---------------------------------------
>
>                 Key: HBASE-19551
>                 URL: https://issues.apache.org/jira/browse/HBASE-19551
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>            Reporter: Toshihiro Suzuki
>            Assignee: Toshihiro Suzuki
>         Attachments: HBASE-19551.patch
>
>
> Currently, in HBaseFsck#checkRegionBoundaries(), it seems like keys from reader.getFirstKey()
and reader.getLastKey() are directly compared by ByteArrayComparator:
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L864-L865
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L869-L870
> This is not correct because the keys consist of a key length and key itself. We should
compare rowkeys or the only key itself (by removing a key length).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message