hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19550) Wrap the Mutation in cp layer to make sure all passed cells are of ExtendedCell
Date Tue, 26 Dec 2017 05:47:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303496#comment-16303496

ramkrishna.s.vasudevan commented on HBASE-19550:

bq.Why not add the default impl of getTag/getTags to ExtendedCell? Not sure whether I had
raised this Q before
I replied to this over in RB. There was a comment saying having an impl for an interface and
just givin default impls does not serve the inheritance purpose. So I first left it with default
impl and then changed that to individual impls. I also noted that it will just be repetition
of code. If we want to address this lets raise a JIRA and fix it. 
BTW I thought you were ok for the commit considering the last reply I had given you in RB.

> Wrap the Mutation in cp layer to make sure all passed cells are of ExtendedCell
> -------------------------------------------------------------------------------
>                 Key: HBASE-19550
>                 URL: https://issues.apache.org/jira/browse/HBASE-19550
>             Project: HBase
>          Issue Type: Task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0-beta-2
>         Attachments: HBASE-19550.v0.patch, HBASE-19550.v1.patch
> We assume all cells in server are of ExtendedCell. However, cp user can add their cell
impl via Put#add(Cell) in observer. That will cause UnsupportedOperationException when rs
try to update the cell's timestamp and seq Id. We should do something for cp user...For example,
wrap the passed cells to be a extendcell type.

This message was sent by Atlassian JIRA

View raw message