hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19531) Remove needless volatile declaration
Date Mon, 18 Dec 2017 11:28:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294835#comment-16294835
] 

Chia-Ping Tsai commented on HBASE-19531:
----------------------------------------

LGTM

> Remove needless volatile declaration
> ------------------------------------
>
>                 Key: HBASE-19531
>                 URL: https://issues.apache.org/jira/browse/HBASE-19531
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Yun-Chi Shih
>            Priority: Trivial
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-19531.v0.patch
>
>
> {code:title=ZKNamespaceManager.java}
> public class ZKNamespaceManager extends ZKListener {
>   private static final Log LOG = LogFactory.getLog(ZKNamespaceManager.class);
>   private final String nsZNode;
>   private volatile NavigableMap<String,NamespaceDescriptor> cache; //here
> {code}
> {code:title=HBaseAdmin.java}
> public class HBaseAdmin implements Admin {
>   private static final Log LOG = LogFactory.getLog(HBaseAdmin.class);
>   private ClusterConnection connection;
>   private volatile Configuration conf; //here
> {code}
> {code:title=BufferedMutatorImpl.java}
> public class BufferedMutatorImpl implements BufferedMutator {
>   private static final Log LOG = LogFactory.getLog(BufferedMutatorImpl.class);
>   private final ExceptionListener listener;
>   private final TableName tableName;
>   private final Configuration conf;
>   private final ConcurrentLinkedQueue<Mutation> writeAsyncBuffer = new ConcurrentLinkedQueue<>();
>   private final AtomicLong currentWriteBufferSize = new AtomicLong(0);
>   /**
>    * Count the size of {@link BufferedMutatorImpl#writeAsyncBuffer}.
>    * The {@link ConcurrentLinkedQueue#size()} is NOT a constant-time operation.
>    */
>   private final AtomicInteger undealtMutationCount = new AtomicInteger(0);
>   private volatile long writeBufferSize;  //here
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message