hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19502) Make sure we have closed all StoreFileScanners if we fail to open any StoreFileScanners
Date Wed, 13 Dec 2017 14:31:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289322#comment-16289322
] 

Hudson commented on HBASE-19502:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1043 (See [https://builds.apache.org/job/HBase-1.2-IT/1043/])
HBASE-19502 Make sure we have closed all StoreFileScanner if we fail to (chia7712: rev 20800f899dbcf827d0f202f3bc5d5633f3df71fa)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java


> Make sure we have closed all StoreFileScanners if we fail to open any StoreFileScanners
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-19502
>                 URL: https://issues.apache.org/jira/browse/HBASE-19502
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0, 1.4.1, 1.2.7, 1.3.3
>
>         Attachments: HBASE-19502.branch-1.4.patch, HBASE-19502.v0.patch
>
>
> {code:title=StoreFileScanner.java}
>   public static List<StoreFileScanner> getScannersForStoreFiles(Collection<StoreFile>
files,
>       boolean cacheBlocks, boolean usePread, boolean isCompaction, boolean canUseDrop,
>       ScanQueryMatcher matcher, long readPt, boolean isPrimaryReplica) throws IOException
{
>     List<StoreFileScanner> scanners = new ArrayList<StoreFileScanner>(files.size());
>     List<StoreFile> sorted_files = new ArrayList<>(files);
>     Collections.sort(sorted_files, StoreFile.Comparators.SEQ_ID);
>     for (int i = 0; i < sorted_files.size(); i++) {
>       StoreFile.Reader r = sorted_files.get(i).createReader(canUseDrop);
>       r.setReplicaStoreFile(isPrimaryReplica);
>       StoreFileScanner scanner = r.getStoreFileScanner(cacheBlocks, usePread, isCompaction,
readPt,
>         i, matcher != null ? !matcher.hasNullColumnInQuery() : false);
>       scanners.add(scanner);
>     }
>     return scanners;
>   }
> {code}
> The missed decrement of ref count will obstruct the cleanup of compacted files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message