hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19496) Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad
Date Wed, 27 Dec 2017 04:34:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304209#comment-16304209
] 

Hudson commented on HBASE-19496:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4293 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4293/])
HBASE-19496 (addendum) don't store the duplicate cp names in (chia7712: rev 5a561e0882313fae5376e8d6b77f26d9f5efe7c6)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerMetrics.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerMetricsBuilder.java
* (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorTableEndpoint.java


> Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad
> -------------------------------------------------------------------------
>
>                 Key: HBASE-19496
>                 URL: https://issues.apache.org/jira/browse/HBASE-19496
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19496.addendum.patch, HBASE-19496.v0.patch, HBASE-19496.v1.patch,
HBASE-19496.v2.patch, HBASE-19496.wip.patch
>
>
> {{ServerLoad}} and {{RegionLoad}} store the pb object internally but the bytebuffer of
pb object may be reused in rpc layer. Hence, the {{ServerLoad}} and {{RegionLoad}} which saved
by {{HMaster}} will be corrupted if the bytebuffer backed is modified.
> This issue doesn't happen on branch-1.
> # netty server was introduced in 2.0 (see HBASE-17263)
> # reusing bytebuffer to read RPC requests was introduced in 2.0 (see HBASE-15788)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message