hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19496) Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad
Date Fri, 22 Dec 2017 16:19:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301617#comment-16301617
] 

Hudson commented on HBASE-19496:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4271 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4271/])
HBASE-19496 Reusing the ByteBuffer in rpc layer corrupt the ServerLoad (chia7712: rev 448ba3a78f50df2ffac874c3768e9f50d52b15f6)
* (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLoad.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/TestSize.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/Size.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterMetricsBuilder.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestBulkLoad.java
* (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterVersionResource.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/BaseTestHBaseFsck.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSource.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java
* (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStatus.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterStatus.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
* (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSink.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerMetrics.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestFavoredStochasticBalancerPickers.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerMetrics.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerMetricsBuilder.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestServerLoadDurability.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/MockMasterServices.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java
* (edit) hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
* (edit) hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterMetrics.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
* (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionMetrics.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterStatusListener.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncDecommissionAdminApi.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionMetrics.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestFavoredStochasticLoadBalancer.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionMetricsBuilder.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionLoad.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterMetrics.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncClusterAdminApi.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java


> Reusing the ByteBuffer in rpc layer corrupt the ServerLoad and RegionLoad
> -------------------------------------------------------------------------
>
>                 Key: HBASE-19496
>                 URL: https://issues.apache.org/jira/browse/HBASE-19496
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19496.v0.patch, HBASE-19496.v1.patch, HBASE-19496.v2.patch,
HBASE-19496.wip.patch
>
>
> {{ServerLoad}} and {{RegionLoad}} store the pb object internally but the bytebuffer of
pb object may be reused in rpc layer. Hence, the {{ServerLoad}} and {{RegionLoad}} which saved
by {{HMaster}} will be corrupted if the bytebuffer backed is modified.
> This issue doesn't happen on branch-1.
> # netty server was introduced in 2.0 (see HBASE-17263)
> # reusing bytebuffer to read RPC requests was introduced in 2.0 (see HBASE-15788)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message