hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19449) Implement SLF4J and SLF4J Parameter Substitution
Date Fri, 08 Dec 2017 03:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283022#comment-16283022
] 

stack commented on HBASE-19449:
-------------------------------

Yeah, my name is messed up in JIRA. Too generic and one of the lads figured its too many aliases
and JIRA baulks.

SLF4J is generally non-native. Comes in via third-parties like ZooKeeper. We do commons-logging
ourselves and backing logger is log4j.

bq. I'm sorry I got a bit overzealous and just threw this patch out there. Thank you for your
interest and the dialogue.

No worries. We love contribs. Glad to have them. Thanks for writing up your motivations.

If interested in the logging story, yeah, we need a revamp. Last time we were thinking about
this was a while back in HBASE-10092 when we were looking at upping to log4j2... But it ain't
ready yet.

Our logging comes up out of what hadoop does. Thats our lineage. Could change it but it would
be substantial change so a new logging basis would need a bit of a writeup and getting some
buy-in up on dev list.

Thanks Beluga.

> Implement SLF4J and SLF4J Parameter Substitution
> ------------------------------------------------
>
>                 Key: HBASE-19449
>                 URL: https://issues.apache.org/jira/browse/HBASE-19449
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbase
>    Affects Versions: 2.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-19449.1.patch, HBASE-19449.2.patch, HBASE-19449.3.patch
>
>
> For the {{HFileArchiver.java}} class...
> * Use SLF4J logging
> * Use SLF4J parameter substitution
> * Fix some small issues with missing spaces between words in the log message and the
like
> https://www.slf4j.org/faq.html#logging_performance



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message