hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19417) Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
Date Tue, 05 Dec 2017 04:46:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278012#comment-16278012
] 

Anoop Sam John commented on HBASE-19417:
----------------------------------------

Ted - I would suggest change the CP hook NOT to return a boolean. Pre hook we changed that
way already

> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
> ------------------------------------------------------------
>
>                 Key: HBASE-19417
>                 URL: https://issues.apache.org/jira/browse/HBASE-19417
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Ted Yu
>         Attachments: 19417.v1.txt, 19417.v2.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the override
of loaded should be placed inside else block:
> {code}
>       } else {
>         // secure bulk load
>         map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region, request);
>       }
>       BulkLoadHFileResponse.Builder builder = BulkLoadHFileResponse.newBuilder();
>       if (map != null) {
>         loaded = true;
>       }
> {code}
> This issue is to address the review comment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message