hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Rodionov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19159) Backup should check permission for snapshot copy in advance
Date Mon, 04 Dec 2017 19:38:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277344#comment-16277344
] 

Vladimir Rodionov commented on HBASE-19159:
-------------------------------------------

lgtm, thanks for the patch [~gubjanos].

> Backup should check permission for snapshot copy in advance
> -----------------------------------------------------------
>
>                 Key: HBASE-19159
>                 URL: https://issues.apache.org/jira/browse/HBASE-19159
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Janos Gub
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HBASE-19159-v2.patch, HBASE-19159-v3.patch, HBASE-19159-v4.patch,
HBASE-19159.patch, initial_patch.txt
>
>
> When the user running the backup doesn't have permission to copy the snapshot , he /
she would see:
> {code}
> 2017-11-02 18:21:33,654 ERROR [main] util.AbstractHBaseTool: Error running command-line
tool
> org.apache.hadoop.hbase.snapshot.ExportSnapshotException: Failed to copy the snapshot
directory: from=hdfs://ctr-e134-1499953498516-263664-01-000003.hwx.site:8020/apps/hbase/data/.hbase-snapshot/snapshot_1509646891251_default_IntegrationTestBackupRestore.table2
to=hdfs://ctr-e134-1499953498516-263664-01-000003.hwx.site:8020/user/root/test-data/fb919a6f-3cb4-4d57-bbcf-561d6e5b3ae8/backupIT/backup_1509646884252/default/IntegrationTestBackupRestore.table2/.hbase-snapshot/.tmp/snapshot_1509646891251_default_IntegrationTestBackupRestore.table2
> 	at org.apache.hadoop.hbase.snapshot.ExportSnapshot.doWork(ExportSnapshot.java:1009)
> 	at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:154)
> 	at org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyJob.copy(MapReduceBackupCopyJob.java:386)
> 	at org.apache.hadoop.hbase.backup.impl.FullTableBackupClient.snapshotCopy(FullTableBackupClient.java:103)
> 	at org.apache.hadoop.hbase.backup.impl.FullTableBackupClient.execute(FullTableBackupClient.java:175)
> 	at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.backupTables(BackupAdminImpl.java:601)
> 	at org.apache.hadoop.hbase.IntegrationTestBackupRestore.runTest(IntegrationTestBackupRestore.java:180)
> 	at org.apache.hadoop.hbase.IntegrationTestBackupRestore.testBackupRestore(IntegrationTestBackupRestore.java:134)
> 	at org.apache.hadoop.hbase.IntegrationTestBackupRestore.runTestFromCommandLine(IntegrationTestBackupRestore.java:263)
> {code}
> It would be more user friendly if the permission is checked before taking the snapshot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message