hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
Date Thu, 14 Dec 2017 19:31:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291427#comment-16291427

Appy commented on HBASE-18838:

bq. Nope. What's going on here is that maven exclusions in modules overwrite the exclusions
in the parent, they are not additive. So by removing the htrace exclusion here, we get to
use the full exclusion list from parent pom.
[~stack] mentioned same thing on HBASE-19349 [in this comment|https://issues.apache.org/jira/browse/HBASE-19349?focusedCommentId=16282697&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16282697].
What about this https://stackoverflow.com/questions/10734565/effect-of-overriding-exclusions-in-maven-dependency?

bq. patch is adding lines with 0 indent.
will take a look and fix this.
Sorry, git patch viewer CSS issue.

bq. Since you introduced shaded.prefix
I was debating this, will go ahead and do it since you asked nicely.

bq. Add a separate exclusion, jic.
it doesn't show up in the maven dep tree, I think we're ok.
had same weirdness up in HBASE-19349. Not in dep tree, but present in binary tarball.

> shaded artifacts are incorrect when built against hadoop 3
> ----------------------------------------------------------
>                 Key: HBASE-18838
>                 URL: https://issues.apache.org/jira/browse/HBASE-18838
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0-alpha-3
>            Reporter: Sean Busbey
>            Assignee: Mike Drob
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>         Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, HBASE-18838.v3.patch
> Building master/branch-2 against the hadoop-3 profile results in check-invariants screaming
about unrelocated dependencies. will list details in comment.

This message was sent by Atlassian JIRA

View raw message