hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10092) Move up on to log4j2
Date Tue, 19 Dec 2017 22:14:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297519#comment-16297519
] 

stack commented on HBASE-10092:
-------------------------------

I tried it.

We'll have to fix transitive include from hadoop... Can do in follow-on

stack@ve0524:~$ ./hbase/bin/start-hbase.sh --config ~/conf_hbase
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/stack/hbase-3.0.0-SNAPSHOT/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/stack/hadoop-3.0.0/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/stack/hbase-3.0.0-SNAPSHOT/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/stack/hadoop-3.0.0/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
ve0524.halxg.cloudera.com: running zookeeper, logging to /home/stack/logs/hbase-stack-zookeeper-ve0524.out
running master, logging to /home/stack/logs/hbase-stack-master-ve0524.out

Log format is the same (duh)

Setting log level works for me (hbase master branch on hadoop3)

This move to slf4j should be a subissue of this one? We are still on log4j backend.

Related, useful blog benchmarking logging frameworks https://www.loggly.com/blog/benchmarking-java-logging-frameworks/





> Move up on to log4j2
> --------------------
>
>                 Key: HBASE-10092
>                 URL: https://issues.apache.org/jira/browse/HBASE-10092
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: Balazs Meszaros
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, HBASE-10092.master.001.patch,
HBASE-10092.master.002.patch, HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  This rather
radical transition can be done w/ minor change given they have an adapter for apache's logging,
the one we use.  They also have and adapter for slf4j so we likely can remove at least some
of the 4 versions of this module our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency resolve hell
courtesy of our slf4j.  Fixing will take some concentration and a good net connection, an
item I currently lack.  Other TODOs are that will need to fix our little log level setting
jsp page -- will likely have to undo our use of hadoop's tool here -- and the config system
changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message